Switch build backend from flit-core to hatch-vcs #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note that .gitignore isn't actually excluded from the sdist, at least currently, since it is needed for hatch(-vcs) to build the wheel
in favor of what hatch-vcs says
since mypy and flake8 both don't like it
There was a problem hiding this comment.
Pull request overview
This PR migrates the build backend from flit-core to hatchling with hatch-vcs for automatic version management from git tags. The change eliminates manual version string maintenance by using VCS-based versioning and removes custom version retrieval logic.
Key changes:
- Replaced flit-core with hatchling and hatch-vcs in the build system
- Automated version management through hatch-vcs with dynamic version import from
_version.py - Simplified version display logic in CLI and panel app by removing git subprocess calls
- Added two new guitar string entries to the D'Addario product data
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updated build backend to hatchling, configured hatch-vcs for version management, and refined build target exclusions |
| stringcalc/init.py | Changed to dynamically import version from hatch-vcs generated _version.py file with fallback to "0.0.0" |
| stringcalc/util.py | Removed entire utility module containing custom git-based version retrieval function |
| stringcalc/cli.py | Simplified version display by parsing version string format instead of executing git subprocess |
| panel/app.py | Simplified get_version() to directly access __version__ attribute without git subprocess fallback |
| .gitignore | Added _version.py to ignore the hatch-vcs generated version file |
| stringcalc/data/daddario-stp.csv | Added two new string product entries (XTNW059 and XTPB028) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.